On 07/10/2019 10:25 am, Thomas Schwinge wrote:
Hi Kwok, Tobias!
On 2019-07-29T21:55:52+0100, Kwok Cheung Yeung <k...@codesourcery.com> wrote:
> if (omp_is_reference (new_var)
> && TREE_CODE (TREE_TYPE (new_var)) != POINTER_TYPE)
As is, this code in lower_omp_target will always reject optional arguments, so
it must be changed. This was introduced in commit r261025 (SVN trunk) as a fix
for PR 85879, but it also breaks support for arrays in firstprivate, which was
probably an unintended side-effect.
Do we have sufficient testsuite coverage for "arrays in firstprivate", in
all languages?
I don't know about other languages, but for Fortran, definitely not. The
only testcase that exercises this AFAIK is optional-firstprivate.f90 in
part 5 of this patch series.
Kwok
