On 10/4/19 12:43 PM, Richard Biener wrote: > On Thu, Oct 3, 2019 at 5:17 PM Bernd Edlinger <bernd.edlin...@hotmail.de> > wrote: >> >> Hi, >> >> this adds -Wshadow=local to the GCC build rules. >> >> It is to be applied after all other patches in this series >> including the trivial ones are applied. >> >> Bootstrapped and reg-tested on x86_64-pc-linux-gnu. >> Is it OK for trunk? > > The -Wshadow=local hunk is obviously OK but there's > a hunk in the patch adding -Wextra as well...?! >
Yes, that replaces -W with -Wextra, I couldn't resist to doing that when I was already there, since gcc -v --help prints: -W This switch is deprecated; use -Wextra instead So the change log says that as well: > * configure.ac (ACX_PROG_CXX_WARNING_OPTS): Use -Wextra instead of -W. > Add -Wshadow=local. Would you like me to split that patch for the -Wextra? Bernd.