On Thu, Oct 3, 2019 at 8:20 AM Bernd Edlinger <bernd.edlin...@hotmail.de> wrote: > > this would normally be a trivial changes, but unless I am mistaken, > I cannot simply commit to the go subtree. Except the -Wshadow=local > warnings this fixes also a few minor memory leaks. > > > Bootstrapped and reg-tested on x86_64-pc-linux-gnu. > Is it OK for trunk? > > > Ian, can you please commit this on my behalf?
Thanks. I don't like the pattern of renaming variables from, e.g., p to p1. In the long run I think that makes the code harder to read and understand. I wrote a different version of the patch, based on yours, and sent it out for review at https://golang.org/cl/198837. I'll commit that one after it is reviewed. Ian
