On Thu, Oct 03, 2019 at 03:17:47PM +0000, Bernd Edlinger wrote: > Hi, > > this fixes -Wshadow=local warnings in the RTL_FLAG_CHECKx macros, > which happen when this macro is used recursively in a macro > argument. The __typeof (RTX) const _rtx in the inner macro > expansions shadows the outer macro expansions. > > So reworked the macro to not use statement expressions but > use templates instead. Since the 7-argument overload is not > used anywhere removed RTL_FLAG_CHECK7 for now.
What effect does this have on the cc1/cc1plus .text sizes? Does this affect debuggability of --enable-checking=yes,rtl compilers? I mean, often when we replace some macros with inlines step in GDB becomes a bigger nightmare, having to go through tons of inline frames. gdbinit.in has a lengthy list of inlines to skip in rtl.h, shouldn't this be added to that list? Not 100% sure how well it will work on rtl checking vs. non-rtl checking builds. Jakub