On 02.10.19 12:19, Thomas Schwinge wrote:
Hi!
On 2019-09-30T15:22:52+0200, Jakub Jelinek <ja...@redhat.com> wrote:
On Mon, Sep 30, 2019 at 03:16:00PM +0200, Andreas Tobler wrote:
here on FreeBSD we lack the alloca.h header so two test cases fail to
compile.
Do the same as I did six years ago for another test case: 'Remove alloca.h
and replace it with __builtin_alloca"
Is this ok for trunk?
TIA,
Andreas
2019-09-30 Andreas Tobler <andre...@gcc.gnu.org>
* testsuite/libgomp.oacc-c-c++-common/loop-default.h: Remove alloca.h
inlcude. Replace alloca () with __builtin_alloca ().
s/inlcude/include/
Because the tests are already using GCC specific builtins
(__builtin_goacc_parlevel_id), I think that is ok, they aren't portable
anyway, CCing Thomas to confirm.
* testsuite/libgomp.oacc-c-c++-common/loop-dim-default.c: Likewise.
Sure, that's fine, and (as far as I'm concerned) pre-approved, should any
additional such changes be necessary later on.
To record the review effort -- not very much here, admittedly ;-) --
please include "Reviewed-by: Thomas Schwinge <tho...@codesourcery.com>"
in the commit log, see <https://gcc.gnu.org/wiki/Reviewed-by>.
I did the commit and hopefully I matched your expectations.
I didn't find an example, so I added the tag similar as we do in FreeBSD.
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=276479
Danke,
Andreas
