Hi!

On Mon, Sep 30, 2019 at 11:36:31AM -0500, Aaron Sawdey wrote:
> This patch uses the support added in the patch I posted last week for 
> actually doing
> inline expansion of memmove().

> I've also removed the code from expand_block_move() for dealing with
> mode==BLKmode because I don't believe that can happen. The big if construct 
> that
> figures out which size we are going to use has a plain else on it, and every
> clause in it sets mode to something other than BLKmode. So I removed that code
> to simplify things and just left a gcc_assert(mode != BLKmode).

That looks fine, with that assert.

> 2019-09-30  Aaron Sawdey <acsaw...@linux.ibm.com>
> 
>       * config/rs6000/rs6000-protos.h (expand_block_move): Change prototype.
>       * config/rs6000/rs6000-string.c (expand_block_move): Add might_overlap 
> parm.

This line is too long...  80 columns max.

>       * config/rs6000/rs6000.md (movmemsi): Add new pattern.
>       (cpymemsi): Add might_overlap parm to expand_block_move() call.


Okay for trunk.  Thanks!


Segher

Reply via email to