On Mon, Sep 30, 2019 at 03:42:34PM +0200, Harwath, Frederik wrote:
>
> Hi Jakub,
>
> Am 30.09.2019 um 09:25 schrieb Jakub Jelinek:
> > On Mon, Sep 30, 2019 at 12:03:00AM -0700, Frederik Harwath wrote:
> >> The patch changes libgomp/libgomp_g.h to include stdint.h instead of the
> >> internal gstdint.h. [...]
> >
> > That looks wrong, will make libgomp less portable. [...]
> > Jakub
>
> We have discussed this issue with Joseph Myers. Let me quote what Joseph
> wrote:
>
> "I think including <stdint.h> is appropriate (and, more generally,
> removing the special configure support for GCC_HEADER_STDINT for
> anything built only for the target - note that libgcc/gstdint.h has a
> comment saying it's about libdecnumber portability to *hosts*, not
> targets, without stdint.h). On any target without stdint.h, GCC should
> be providing its own; the only targets where GCC does not yet know about
> target stdint.h types are SymbianOS, LynxOS, QNX, TPF (see GCC bug 448),
> and I think it's pretty unlikely libgomp would do anything useful for
> those (and if in fact they do provide stdint.h, there wouldn't be an
> issue anyway)."
>
> Hence, I think the change will not affect portability negatively.
Ok for trunk then, I'll test removal of the gstdint.h traces from libgomp as a
follow-up.
Jakub
