Hi!
On Tue, Sep 24, 2019 at 01:59:07AM -0400, Michael Meissner wrote:
> +;; Return true if the operand is a PC-relative address to a local symbol or a
> +;; label that can be used directly in a memory operation.
"address of", not "address to"?
> +/* Different PowerPC instruction formats that are used by GCC. There are
> + various other instruction formats used by the PowerPC hardware, but the
> + these formats are not currently used by GCC. */
"the these".
> +enum non_prefixed {
> + NON_PREFIXED_DEFAULT, /* Use the default. */
> + NON_PREFIXED_D, /* All 16-bits are valid. */
> + NON_PREFIXED_DS, /* Bottom 2 bits must be 0. */
> + NON_PREFIXED_DQ, /* Bottom 4 bits must be 0. */
> + NON_PREFIXED_X /* No offset memory form exists. */
> +};
Please call the enum non_prefixed_form.
With those nits fixed, this is fine for trunk. Thank you!
Segher
