On Thu, Sep 19, 2019 at 3:59 PM Mark Eggleston <mark.eggles...@codethink.co.uk> wrote: > > Original thread: https://gcc.gnu.org/ml/fortran/2019-09/msg00024.html > > The original patch introduced a new field in gfc_typespec called length > to be used only for character literals. At the time I felt that this was > a bit of kludge. As a results of comments from Janne Blomqvist I > investigated whether the existing mechanism for character length in > gfc_typespec could be used for character literals. This turn out to be > impractical. > > The character length for literals is already held in the gfc_expr > structure for character constants. I've added a new version of > gfc_typename that accepts gfc_expr * instead of gfc_typespec. Where > character types are possible the gfc_expr * version is now used instead > of the gfc_typespec * version. > > I've implemented Janne's suggestions. > > I think this is a better solution. > > Please review. > > Tested on x86_64 (built with bootstrap).
Thanks, this is Ok. -- Janne Blomqvist