On Sat, Sep 14, 2019 at 02:27:15PM +0200, Thomas Koenig wrote:
>
> the attached patch improves the rather hard to read error
> messages for argument mismatches. With this patch, this reads
>
> argument_checking_21.f90:7:11:
>
> 6 | call foo(1.0) ! { dg-warning "Rank mismatch" }
> | 2
> 7 | call foo(b) ! { dg-warning "Rank mismatch" }
> | 1
> Fehler: Rank mismatch between actual argument at (1) and actual argument
> at (2) (scalar and rank-2)
>
> which I think is fairly clear. It also makes sure that warnings are
> always emitted by -fallow-argument-mismatch by removing
> -Wargument-mismatch. Finally, for people who do not want to have too
> many warnings cluttering up their logs, a type mismatch is only
> shown once if it is a warning.
>
> While I was going on about fixing warnings, I also fixed PR 91557 with
> the bit in trans-expr.c. This part is trivial, I will backport it
> to the other affected branches.
>
> After this, I think we can close PR 91556. Regression-tested. OK for
> trunk?
>
Looks good to me. Thanks for working of this issue.
--
Steve
20170425 https://www.youtube.com/watch?v=VWUpyCsUKR4
20161221 https://www.youtube.com/watch?v=IbCHE-hONow
