On Mon, Nov 21, 2011 at 7:07 AM, Revital Eres <revital.e...@linaro.org> wrote: > Hello, > > This patch support the estimation of register pressure in SMS. > Although GCC is in stage 3 I would appreciate comments on it. > Thanks to Richard and Ayal for discussing the implementation and their > insights. > > This part of the patch enables iterating on the partial schedule in the > reverse order (from the last instruction the the first). > > Tested and bootstrap with the other patches in the series on > ppc64-redhat-linux, > enabling SMS on loops with SC 1. > > Comments are welcome. >
This looks fine. Please rename rows_reverse to rows_last as discussed, and simplify the bit that tracks last_in_row in ps_insn_find_column(). Thanks, Ayal. > Thanks, > Revital > > Changelog: > * modulo-sched.c (rows_reverse): New field in struct partial_schedule. > (create_partial_schedule, free_partial_schedule, > ps_insert_empty_row, ps_insn_advance_column, > ps_insn_find_column, remove_node_from_ps, reset_partial_schedule, > rotate_partial_schedule, verify_partial_schedule): Update the > new field. >