Hi Jakub, thanks for your detailed comments. > Can you please try to tweak your mailer settings? In the text version of > the patch the mailer ate tab characters, so the patch can't apply, and in > the html version which we generally don't want to see on the mailing list, > one has to open it in some web browser, copy from there and replace \n\n > with \n to get something that can apply. I blindly ran clang-format before submission, I'll try to comply with the formatting standards by hand next time. And about the mailer, I think copy-pasting through a text editor ate all the tabs. I'll try to do something about my mailer. Sorry for the inconvenience. > Generally, we don't want to have code commented out like this in the final > patch submission. For this WIP, I think it is acceptable, as I think in the > end you don't want to use the team's queue, but actually either > children_queue (renamed), but only use it on the implicit tasks, or during Can you elaborate? What do you mean by "children_queue (renamed)"?
> team creation allocate together with the team structure also memory that > would be used as a trailing array for an array of the implicit queues next > to the array of implicit tasks. Do you mean to make two trailing arrays in gomp_team? Also, this is a personal question, why do gcc prefer trailing arrays over dynamically allocated pointers? Thank you again for your detailed comments, I'll do my best for the rest of GSoC Ray Kim
