On 7/17/19 10:44 AM, luoxhu wrote: > Hi Martin, > > On 2019/7/17 15:55, Martin Liška wrote: >> On 7/17/19 7:44 AM, luoxhu wrote: >>> Hi Martin, >>> Thanks for your review, v4 Changes as below: >>> 1. Use decrease bubble sort. >>> BTW, I have a question about hist->hvalue.counters[2], when will it become >>> -1, please? Thanks. Currently, if it is -1, the function will return >>> false. >> >> Hi. >> >> Thanks for that. I made a minor changes to your patch, please see it in >> attachment. >> -1 is a value that we use for invalidated histogram. That happens when you >> need >> to fit in more values during instrumentation than you have counters in the >> histogram. >> It helps to make reproducible builds of a software. > Thanks for your patience with many tiny fixes. I will install the updated > patch to trunk.
Please wait for an approval of a maintainer, I'm not one of them ;) Thanks, Martin > > Xionghu > >> >> Martin >> >
