On 7/11/19 10:08 PM, Andrew Pinski wrote: > On Mon, Jul 8, 2019 at 12:39 AM JiangNing OS > <jiangn...@os.amperecomputing.com> wrote: >> >> Hi Jeff and Richard B., >> >> Following your tips, I've found a much simpler solution in >> tree-ssa-phiopt.c. Attached is the new patch. Review again, please! > > /* Prove that we can move the store down. We could also check > TREE_THIS_NOTRAP here, but in that case we also could move stores, > whose value is not available readily, which we want to avoid. */ > > I think the comment above the change needs to be changed or extended slightly. Actually, I don't think that comment needs to change. But the one before cond_store_replacement needs minor updating which I'll take care of.
My reasoning is that addressables in the local stack are most likely going to already have their lines in the cache and thus are available readily. Jeff
