On 12-06-19 12:22, Jakub Jelinek wrote: > On Fri, Jun 07, 2019 at 03:08:37PM +0100, Julian Brown wrote: >> diff --git a/gcc/omp-low.c b/gcc/omp-low.c >> index a7f35ffe416..67e1e82ec00 100644 >> --- a/gcc/omp-low.c >> +++ b/gcc/omp-low.c >> @@ -9794,6 +9882,8 @@ lower_omp_target (gimple_stmt_iterator *gsi_p, >> omp_context *ctx) >> >> if (offloaded) >> { >> + mark_oacc_gangprivate (&ctx->oacc_addressable_var_decls, ctx); >> + > > The above one still doesn't seem to be guarded for OpenACC constructs only. > > As for the rest of the patch, you need Tom to look over the nvptx changes.
I haven't seen any nvptx changes mentioned since I ok-ed the nvptx part ( https://gcc.gnu.org/ml/gcc-patches/2018-10/msg00324.html ), so on that basis I'd say it's still ok. Thanks, - Tom