On Fri, Jun 07, 2019 at 07:31:39PM -0400, Michael Meissner wrote: > Ok, here is the revised version of the patch. -mcpu=future sets > -mprefixed-addr but not -mpcrel. Using either -mpcrel or -mprefixed-addr does > not set -mcpu=future. I tweaked the tests for -mpcrel and -mprefixed-addr > somewhat, and kept the changes to the testsuite.
> -/* Support for a future processor's features. */ > +/* Support for a future processor's features. Do not enable -mpcrel until is > + fully functional. */ > #define ISA_FUTURE_MASKS_SERVER (ISA_3_0_MASKS_SERVER > \ > | OPTION_MASK_FUTURE \ > - | OPTION_MASK_PCREL \ > | OPTION_MASK_PREFIXED_ADDR) "until it is". Or just say "Do not enable -mpcrel yet." ;-) > - /* -mpcrel requires prefixed load/store addressing. */ > - if (TARGET_PCREL && !TARGET_PREFIXED_ADDR) > + /* -mprefixed-addr (and hence -mpcrel) requires -mcpu=future. */ > + if ((TARGET_PREFIXED_ADDR || TARGET_PCREL) && !TARGET_FUTURE) You don't really need to test for PCREL here, the > + /* -mpcrel requires prefixed load/store addressing. */ > + if (TARGET_PCREL && !TARGET_PREFIXED_ADDR) test will error in that case already. Okay for trunk with the grammar thing fixed. Thanks! Segher
