On 6/4/19 3:07 PM, Maciej W. Rozycki wrote: > On Mon, 3 Jun 2019, Faraz Shahbazker wrote: > >> The __pool and __pend symbols are used to mark the beginning and end of >> inline constant pools in MIPS16 code regions. However if the pool occurs >> at the boundary of a code region and is not followed by further code, >> presence of the __pend symbol can confuse the dissassembler in to treating >> subsequent non-MIPS16 code block as MIPS16. > > Thanks for looking into it. FWIW I think the `__pend' symbol will best > be still emitted for consistency, however as STT_OBJECT and consequently > with no trailing `.insn'. If I understand correctly we'd still want to call mips_set_text_contents_type in all the cases we did before, but that we'd pass in false for the FUNCTION_P argument?
jeff