I posted the patch right on the cusp of stage 4, thinking it was still stage 3. I thought I could finish it quickly but after the last round of comments I decided to move on to stage 4 stuff. I've contemplating coming back to it at some point.
That being said, the patch fixes the reported bug with no issues. While the comments may be valid, as often happens, by insisting on perfection we let the perfect be the enemy of the good enough: the correctness bug remains unresolved and the effort that went into the fix may have been for naught. Martin On 6/3/19 9:20 AM, Joseph Myers wrote:
I already reviewed two versions of this patch. As far as I know, no third version has been posted to address my comments on the second version <https://gcc.gnu.org/ml/gcc-patches/2019-01/msg00970.html>.
