On Mon, Jun 03, 2019 at 05:51:26PM +0200, Thomas Schwinge wrote:
> Hi!
>
> On Fri, 31 May 2019 10:56:43 -0700, Ian Lance Taylor <i...@golang.org> wrote:
> > This libgo patch by Cherry Zhang implements cheaper goroutine context
> > switches on x86_64 GNU/Linux. [...]
>
> > Bootstrapped and tested on x86_64-pc-linux-gnu. Committed to mainline.
>
> > --- libgo/runtime/go-context.S (nonexistent)
> > +++ libgo/runtime/go-context.S (working copy)
>
> > + andq $~0xfULL, %rdx
>
> I run into:
>
> [...]/libgo/runtime/go-context.S: Assembler messages:
> [...]/libgo/runtime/go-context.S:60: Error: junk `ULL' after expression
> make[4]: *** [runtime/go-context.lo] Error 1
>
> ... with (admittedly somewhat old) Binutils:
>
> $ as --version | head -n 2
> GNU assembler (GNU Binutils for Ubuntu) 2.22.90.20120924
> Copyright 2012 Free Software Foundation, Inc.
As andq immediate is just 32-bit, I'd say using $~0xf or $-16 instead of
$~0xfULL is the right fix.
Jakub
