* Segher Boessenkool:
> On Thu, May 23, 2019 at 10:33:28PM +0000, Joseph Myers wrote:
>> On Tue, 21 May 2019, Segher Boessenkool wrote:
>>
>> > > I think having author names and email addresses is a basic requirement
>> > > of
>> > > any reasonable repository conversion
>> >
>> > Yes, and they should be the same as they were in the original repository.
>>
>> That's what the "changelogs" feature in reposurgeon does, when the commit
>> that made the change also added a ChangeLog entry.
>>
>> In the case where the commit didn't add a ChangeLog entry, a name and
>> email address from an author map is the best we can practically do (and I
>
> IMO the best we can do is use what we already have: what CVS or SVN used
> as the committer identity. *That* info is *correct* at least.
>
> In many cases we can glance someone's real name from the changelog, sure.
> People looking up things can trivially do that, and with much better
> accuracy than any script can. In some other cases you cannot, no matter
> how hard you try.
Looking at the git fsck sources, I think you have to fake an email address:
if (*p == '<')
return report(options, obj, FSCK_MSG_MISSING_NAME_BEFORE_EMAIL,
"invalid author/committer line - missing space before email");
p += strcspn(p, "<>\n");
if (*p == '>')
return report(options, obj, FSCK_MSG_BAD_NAME, "invalid
author/committer line - bad name");
if (*p != '<')
return report(options, obj, FSCK_MSG_MISSING_EMAIL, "invalid
author/committer line - missing email");
if (p[-1] != ' ')
return report(options, obj,
FSCK_MSG_MISSING_SPACE_BEFORE_EMAIL, "invalid author/committer line - missing
space before email");
p++;
p += strcspn(p, "<>\n");
if (*p != '>')
return report(options, obj, FSCK_MSG_BAD_EMAIL, "invalid
author/committer line - bad email");
p++;
But something like “fw <fw>” would probably be acceptable.
Thanks,
Florian
