On 5/10/19 7:14 PM, Jakub Jelinek wrote:
On Fri, May 10, 2019 at 04:26:47PM -0400, Jason Merrill wrote:
That is strange.  That seems to go back to

Surely we should only set the incr location if it doesn't already have one,
as would have been the case before that patch.

So, like this then?  Bootstrapped/regtested again on x86_64-linux and
i686-linux:

2019-05-11  Jakub Jelinek  <ja...@redhat.com>

        PR debug/90197
        * cp-gimplify.c (genericize_cp_loop): Emit a DEBUG_BEGIN_STMT
        before the condition (or if missing or constant non-zero at the end
        of the loop.  Emit a DEBUG_BEGIN_STMT before the increment expression
        if any.  Don't call protected_set_expr_location on incr if it already
        has a location.

OK, thanks.

Jason

Reply via email to