Hi Iain, On Wed, May 15, 2019 at 12:54:03PM +0100, Iain Sandoe wrote: > If we build Darwin with a modern assembler, then it might well > recognise insns that cannot be used on current Darwin systems. > > The patch augments the tests for feature support for VSX, > power8 and power9 to exclude Darwin even if the assembler can > handle the instructions.
Cannot be used, in what way? *_ok test only if we can *compile* for some subtarget. What blows up? The current tests aren't great, we should compile some actual code to test if the compiler allows building for p8 for example -- more than just the assembler. Maybe it is enough to have some register input that requires VSX registers on the asm in the test, for example. Segher
