Re: [PATCH][stage1] Prefer to use strlen call instead of inline expansion (PR target/88809).

[Martin Liška]

On 5/2/19 11:36 PM, Jakub Jelinek wrote:
> On Tue, Apr 30, 2019 at 10:00:07AM -0600, Jeff Law wrote:
>>> 2019-04-23  Martin Liska  <mli...@suse.cz>
>>>
>>>     PR target/88809
>>>     * config/i386/i386.c (ix86_expand_strlen): Use strlen call.
>>>     With -minline-all-stringops use inline expansion using 4B loop.
>>>     * doc/invoke.texi: Document the change of
>>>     -minline-all-stringops.
>>>
>>> gcc/testsuite/ChangeLog:
>>>
>>> 2019-04-23  Martin Liska  <mli...@suse.cz>
>>>
>>>     PR target/88809
>>>     * gcc.target/i386/pr88809.c: New test.
>>>     * gcc.target/i386/pr88809-2.c: New test.
>> OK for the trunk.
> 
> The pr88809-2.c test fails on i686-linux.
> spawn -ignore SIGHUP /home/jakub/src/gcc/obj31/gcc/xgcc 
> -B/home/jakub/src/gcc/obj31/gcc/ 
> /home/jakub/src/gcc/gcc/testsuite/gcc.target/i386/pr88809-
> 2.c -fno-diagnostics-show-caret -fno-diagnostics-show-line-numbers 
> -fdiagnostics-color=never -Os -ffat-lto-objects -fno-ident -S -o pr88809-2.s
> PASS: gcc.target/i386/pr88809-2.c (test for excess errors)
> FAIL: gcc.target/i386/pr88809-2.c scan-assembler call[ \t]strlen
> 
>       Jakub
> 

There's an obvious fix that I tested with:

$ make check -k RUNTESTFLAGS="i386.exp=pr88809* --target_board=unix/-m32/"
and
$ make check -k RUNTESTFLAGS="i386.exp=pr88809*"

I'm going to install the patch soon.
Martin

>From 912f89777713120d23085d589602da421e16cde0 Mon Sep 17 00:00:00 2001
From: marxin <mli...@suse.cz>
Date: Fri, 3 May 2019 10:58:42 +0200
Subject: [PATCH] Fix test-case for i386 (PR target/88809).

gcc/testsuite/ChangeLog:

2019-05-03  Martin Liska  <mli...@suse.cz>

	PR target/88809
	* gcc.target/i386/pr88809-2.c: Scan for call or jmp.
---
 gcc/testsuite/gcc.target/i386/pr88809-2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.target/i386/pr88809-2.c b/gcc/testsuite/gcc.target/i386/pr88809-2.c
index b8ef51dab5b..8ff3499831d 100644
--- a/gcc/testsuite/gcc.target/i386/pr88809-2.c
+++ b/gcc/testsuite/gcc.target/i386/pr88809-2.c
@@ -6,4 +6,4 @@ unsigned int foo (const char *ptr)
   return __builtin_strlen (ptr);
 }
 
-/* { dg-final { scan-assembler "call\[ \t\]strlen" } } */
+/* { dg-final { scan-assembler "(call|jmp)\[ \t\]strlen" } } */
-- 
2.21.0