Hi, This fixes three tests that regressed because the regex wasn’t flexible enough to cope with codegen changes.
Will backport once 9 opens. thanks Iain Index: gcc/testsuite/ChangeLog =================================================================== --- gcc/testsuite/ChangeLog (revision 270796) +++ gcc/testsuite/ChangeLog (working copy) @@ -1,3 +1,10 @@ +2019-05-02 Iain Sandoe <i...@sandoe.co.uk> + + * gcc.dg/tree-prof/section-attr-1.c: Update scan-asm regex + for cold section label. + * gcc.dg/tree-prof/section-attr-2.c: Likewise. + * gcc.dg/tree-prof/section-attr-3.c: Likewise. + 2019-05-02 Rainer Orth <r...@cebitec.uni-bielefeld.de> * gcc.target/i386/spellcheck-options-5.c: Restrict to Linux and Index: gcc/testsuite/gcc.dg/tree-prof/section-attr-1.c =================================================================== --- gcc/testsuite/gcc.dg/tree-prof/section-attr-1.c (revision 270796) +++ gcc/testsuite/gcc.dg/tree-prof/section-attr-1.c (working copy) @@ -47,4 +47,4 @@ } /* { dg-final-use { scan-assembler "\.section\[\t \]*\.text\.unlikely\[\\n\\r\]+\[\t \]*\.size\[\t \]*foo\.cold" { target *-*-linux* *-*-gnu* } } } */ -/* { dg-final-use { scan-assembler "\.section\[\t \]*__TEXT,__text_cold\*\[\\n\\r\]+_foo\.cold" { target *-*-darwin* } } } */ +/* { dg-final-use { scan-assembler {.section[\t ]*__TEXT,__text_cold[^\n]*[\n\r]+_foo.cold:} { target *-*-darwin* } } } */ Index: gcc/testsuite/gcc.dg/tree-prof/section-attr-2.c =================================================================== --- gcc/testsuite/gcc.dg/tree-prof/section-attr-2.c (revision 270796) +++ gcc/testsuite/gcc.dg/tree-prof/section-attr-2.c (working copy) @@ -46,4 +46,4 @@ } /* { dg-final-use { scan-assembler "\.section\[\t \]*\.text\.unlikely\[\\n\\r\]+\[\t \]*\.size\[\t \]*foo\.cold" { target *-*-linux* *-*-gnu* } } } */ -/* { dg-final-use { scan-assembler "\.section\[\t \]*__TEXT,__text_cold\*\[\\n\\r\]+_foo\.cold:" { target *-*-darwin* } } } */ +/* { dg-final-use { scan-assembler {.section[\t ]*__TEXT,__text_cold[^\n]*[\n\r]+_foo.cold:} { target *-*-darwin* } } } */ Index: gcc/testsuite/gcc.dg/tree-prof/section-attr-3.c =================================================================== --- gcc/testsuite/gcc.dg/tree-prof/section-attr-3.c (revision 270796) +++ gcc/testsuite/gcc.dg/tree-prof/section-attr-3.c (working copy) @@ -47,4 +47,4 @@ } /* { dg-final-use { scan-assembler "\.section\[\t \]*\.text\.unlikely\[\\n\\r\]+\[\t \]*\.size\[\t \]*foo\.cold" { target *-*-linux* *-*-gnu* } } } */ -/* { dg-final-use { scan-assembler "\.section\[\t \]*__TEXT,__text_cold\*\[\\n\\r\]+_foo\.cold:" { target *-*-darwin* } } } */ +/* { dg-final-use { scan-assembler {.section[\t ]*__TEXT,__text_cold[^\n]*[\n\r]+_foo.cold:} { target *-*-darwin* } } } */