On Thu, Apr 25, 2019 at 11:02:09AM -0500, Kelvin Nilsen wrote:
> The attached patch resolves the issue described in this problem report. The
> patch has been bootstrapped and tested without regressions on
> powerpc64le-unknown-linux-gnu (both P8 and P9) and on powerpc64-linux (P7 and
> P8, both -m32 and -m64).
>
> Is this ok for trunk and backports?
It is okay for trunk and backports, but you may want to hold off until
after the GCC 9 release. For the gcc-9 branch you need the RMs' approval.
A few testcase comments:
> --- gcc/testsuite/gcc.target/powerpc/pr89424-0.c (nonexistent)
> +++ gcc/testsuite/gcc.target/powerpc/pr89424-0.c (working copy)
> @@ -0,0 +1,78 @@
> +/* { dg-do run { target { powerpc*-*-* && lp64 } } } */
> +/* { dg-skip-if "" { powerpc*-*-darwin* } } */
> +/* { dg-require-effective-target vsx_hw } */
I think such "darwin" lines are useless; vsx_hw will not be true on Darwin.
> +/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { } }
> */
We do not need this anymore either (and this test never needed it).
> +/* { dg-options "-mvsx" } */
Thanks,
Segher
