On Sat, 20 Apr 2019 at 22:30, Thomas Schwinge <tho...@codesourcery.com> wrote: > > Hi! > > On Tue, 18 Sep 2018 02:39:46 +0200, Iain Buclaw <ibuc...@gdcproject.org> > wrote: > > This patch adds the configure and make files used for building D > > runtime and Phobos. As well as running all unittests and the > > testsuite. > > With a x86_64-pc-linux-gnu build, I've noticed breakage in '-m32' > multilib testing, made apparent by message: "[...]: > /lib/i386-linux-gnu/libgcc_s.so.1: version `GCC_7.0.0' not found > (required by [...])". (That is, the system 'libgcc_s.so.1' being > dynamically linked instead of the just built one.) This is because of > incomplete 'gccdir' setup in the '*.exp' file. In such a multilibbed > configuration, there are 'build-gcc/gcc/libgcc.*' and > 'build-gcc/gcc/32/libgcc.*' (for example); for '-m32' multilib testing, > paths need to be set up to point to the latter instead of the former. It > seems as if some of this '*.exp' stuff has been copied from libffi (?); > the attached patch copies the missing pieces from there, too. I've been > tempted to commit this "as obvious", but then thought I'll still get some > review/approval first. If approving this patch, please respond with > "Reviewed-by: NAME <EMAIL>" so that your effort will be recorded in the > commit log, see <https://gcc.gnu.org/wiki/Reviewed-by>. >
Seems reasonable to me. -- Iain
