From: Eric Botcazou <ebotca...@adacore.com>
Date: Sun, 13 Nov 2011 00:26:51 +0100

>> Again, only those ELF targets which have an override for
>> ASM_GENERATE_INTERNAL_LABEL, which if you check is almost entirely
>> Sparc.
> 
> We probably aren't looking at the same tree then.  Alpha, IA-64, MIPS, HP-PA, 
> SPARC and a few others have an override for ASM_GENERATE_INTERNAL_LABEL.

I am aware of these cases.

And when I took at look at them it seemed to me that these base target
headers where you see those defines either do not get used alongside
elfos.h or will come before elfos.h in the tmake file listing, thus
the elfos.h definition will take precedence.

On the other hand, on Sparc, the overrides occur in OS specific target
headers which appear after elfos.h in the tmake header file list.

>> The normal thing to do is to use the elfos.h defines as-is.
> 
> Target macros are meant to be overridden though.  If an implicit dependency 
> has 
> been introduced, then it should be documented and the tree should be audited.

Agreed.

Reply via email to