On Wed, Apr 17, 2019 at 01:25:05PM +0200, Jakub Jelinek wrote:
> On Wed, Apr 17, 2019 at 02:09:33PM +0300, Claudiu Zissulescu wrote:
> > /* Warn for unimplemented PIC in pre-ARC700 cores, and disable flag_pic.
> > */
> > if (flag_pic && TARGET_ARC600_FAMILY)
> > {
> > warning (0,
> > - "PIC is not supported for %s. Generating non-PIC code only..",
> > + "PIC is not supported for %s. Generating non-PIC code only",
> > arc_cpu_string);
>
> I believe this is undesirable too. Either use something like
> "PIC is not supported for %s; generating non-PIC code only"
> or split that into two messages
> if (warning (0, "PIC is not supported for %s", arc_cpu_string))
> inform (input_location, "generating non-PIC code only");
And I suppose we should avoid pleonasm like "PIC code" ;).
Marek
