On Wed, 10 Apr 2019 at 01:58, Jim Wilson <j...@sifive.com> wrote: > > On Tue, Apr 9, 2019 at 10:36 AM Iain Buclaw <ibuc...@gdcproject.org> wrote: > > Any objection if I upstream the non-asm bits? > > Doesn't all of it, except maybe the configure.tgt patch need to go > upstream first? And do you need some paperwork or button click from > David for D language patches for the copyright assignment? >
There is nothing to be signed, only the compiler front-end itself has such a process in place. > Is there a problem with the asm bits? The fenv.h functions like > fegetenv could be used for this, assuming you can include a C header > file in D code. But if this is the D language implementation of > fenv.h, then you probably can't avoid the assembly code. > The asm syntax is specific to gdc, and there's not presently a policy in place to upstream them (each module that contains deviations is appropriately marked at the top of the file) . Ideally asm bits should be in separate modules, then it would just be a case of swapping upstreams for our own. The FloatingPointControl struct is more closely related to fpu-control.h. And no, you can't just include C headers from the D compiler. that would make quite a lot of things simpler if it did. Iain.
