Re: [Patch, libstdc++.exp]Update the usage of cached result, rebuild nlocale wrapper for each variant.

[Jonathan Wakely]

On 11/03/19 11:54 +0000, Jonathan Wakely wrote:

Hi, I've just noticed this in your r266209 change from November:

On 16/11/18 10:42 +0000, Renlin Li wrote:

+    return [check_v3_target_prop_cached et_parallel_mode {
+       global cxxflags
+       global v3-libgomp
        # If 'make check-parallel' is running the test succeeds.
        if { ${v3-libgomp} == 1 && [regexp "libgomp" $cxxflags] } {
-           set et_parallel_mode 1
+           return1 1

Is this a typo? It should be "return 1" not "return1 1" right?

I've committed this fix to trunk.



commit 116f85727b49103ff3c8d4fb152c7a6047eb3546
Author: Jonathan Wakely <jwak...@redhat.com>
Date:   Wed Apr 10 15:44:35 2019 +0100

    Fix typo in effective-target check
    
            * testsuite/lib/libstdc++.exp (check_v3_target_parallel_mode): Fix
            typo.

diff --git a/libstdc++-v3/testsuite/lib/libstdc++.exp b/libstdc++-v3/testsuite/lib/libstdc++.exp
index 5a12ac0242d..d0efc90a1ba 100644
--- a/libstdc++-v3/testsuite/lib/libstdc++.exp
+++ b/libstdc++-v3/testsuite/lib/libstdc++.exp
@@ -1048,7 +1048,7 @@ proc check_v3_target_parallel_mode { } {
 	global v3-libgomp
 	# If 'make check-parallel' is running the test succeeds.
 	if { ${v3-libgomp} == 1 && [regexp "libgomp" $cxxflags] } {
-	    return1 1
+	    return 1
 	}
 	return 0
     }]