On Tue, Mar 26, 2019 at 02:34:40PM +0100, Richard Biener wrote: > Just found this in one of my dev trees and think it's suitable at > this stage as a general speedup. > > gimple_block involves querying an on-the-side map in libcpp > since it is encoded in the location_t location. This means > caching is beneficial. It's also pointless to copy > gimple_block once you've copied gimple_location.
The removals of gimple_set_block means we can't at some point change our minds easily and put block somewhere else, but guess that we'd need to go through all spots that copy location now anyway. So LGTM. Jakub