On 3/18/19 10:59 AM, Martin Sebor wrote:
> On 3/17/19 11:24 AM, Sandra Loosemore wrote:
>> On 3/4/19 5:28 PM, Martin Sebor wrote:
>>> Attached is a patch with (mostly) my changes for GCC 9. To make
>>> things easier to find I grouped related changes together within
>>> the sections I changed. I put warnings under the same bullet,
>>> built-ins, and attributes.
>>
>> I have a few nit-picky comments...
>>
>> s/command line option/command-line option/g
>> s/command line utilitly/command-line utility/ (typo, not just hyphen)
>> s/red-zones/red zones/g
>
> Fixed.
>
>>
>> Please try to reformat this to avoid lines longer than 80 characters,
>> except where it's unavoidable in <a href="..."> markup.
>
> I spotted just a couple of lines in the diff that were exactly
> 80 characters long but I'm not sure where else this could be
> done. AFAICS, all the long lines I added are because of
> the <a href="..."> tags.
>
> There are a few lines in the file that the patch doesn't touch
> that are a few characters over 80. Because of the <a href...>
> tags and the overall lack of consistency in indentation (two vs
> four spaces) I don't think it matters enough here to spend time
> changing.
>
> Martin
>
> PS We could fit most lines into 80 characters by introducing some
> macro for all the <a href="gcc-option.html> tags. That would make
> it easier to insert these links too. E.g.,
> <option>-falign-functions</option> could be expanded by some
> post-processing script into
>
> <a
> href="https://gcc.gnu.org/onlinedocs/gcc-9.1.0/gcc/Optimize-Options.html#index-falign-functions";><code>-falign-functions</code></a>
>
>
> That way the option links would also continue to work even if
> in some later release the options were removed or renamed. (In
> GCC 8 I made the links point at the gcc-8.1.0 docs but I haven't
> done it here.) I don't know enough about how these files are
> processed to do this.
>
> gcc-9-changes.diff
OK
jeff
