On 3/11/19 2:13 AM, Martin Liška wrote:
Hi.
The patch adds a lot of option name wrapping in string format messages. I added
a new contrib
script (contrib/check-internal-format-escaping.py) that is parsing gcc.pot file
and reports
errors.
Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
Apart from that I built all cross compilers and compared all warnings so that
I don't introduce a bootstrap error. It's expected that various target-specific
tests will need wrapping in scanned patterns.
This looks great to me. One change I would consider is making
the built-in and option strings arguments to %qs rather than
parts of the format strings. That should reduce the overall
number of format strings that need to be translated, and also
make it easier to spot inconsistencies between the phrasing
or opportunities to make the phrasing more uniform.
(I still plan to work on the warning we said we'd add to keep
the missing quoting from creeping back in.)
Martin
Is it fine for next stage1?
Thanks,
Martin
