On Mon, Feb 11, 2019 at 12:20:42PM -0700, Martin Sebor wrote:
> --- gcc/c-family/c-attribs.c (revision 268774)
> +++ gcc/c-family/c-attribs.c (working copy)
> @@ -4032,8 +4032,12 @@ validate_attribute (location_t atloc, tree oper, t
>
> if (TYPE_P (oper))
> tmpdecl = build_decl (atloc, TYPE_DECL, tmpid, oper);
> + else if (DECL_P (oper))
> + tmpdecl = build_decl (atloc, TREE_CODE (oper), tmpid, TREE_TYPE (oper));
> + else if (EXPR_P (oper))
> + tmpdecl = build_decl (atloc, TYPE_DECL, tmpid, TREE_TYPE (oper));
> else
> - tmpdecl = build_decl (atloc, TREE_CODE (oper), tmpid, TREE_TYPE (oper));
> + return false;
>
> /* Temporarily clear CURRENT_FUNCTION_DECL to make decl_attributes
> believe the DECL declared above is at file scope. (See bug 87526.) */
Why do you this kind of validation at all? You do compare the arguments
later on in the caller, why isn't that sufficient? Creating some decl (and
ignoring for that whether the attribute is decl_required, type_required and/or
function_type_required) is a sure way to get many warnings, even if the
arguments are reasonable.
Jakub
