On 08/11/2011 18:12, Rainer Orth wrote:
> Dave Korn writes:
>
>> Notice how in your additions, you prepend the t-mingw-pthread file to the
>> list in $tmake_file rather than append it as the existing code does.
>> Ordering
>> of t-* files in $tmake_file is significant as there may be overrides and
>> files
>> should be listed from most generic to most target/os-specific, so please
>> adjust those two hunks to match the way it's already being done.
>
> Huh? I've done it exactly the way it had been in gcc/config.gcc before
> my patch series:
>
> case ${enable_threads} in
> "" | yes | win32) thread_file='win32'
> tmake_file="${tmake_file} i386/t-gthr-win32"
> ;;
> posix)
> thread_file='posix'
> tmake_file="i386/t-mingw-pthread ${tmake_file}"
> ;;
> esac
>
> Why should this suddenly be wrong in libgcc?
Hm. Well, it must have been inconsistent when it was added there in the
first place, so I guess since it hasn't been a problem yet there's no need to
fix it now. Patch is OK as-is then.
cheers,
DaveK
