On Tue, 5 Feb 2019, Jakub Jelinek wrote: > Hi! > > The r253411 change to improve diagnostics added code to set DECL_ARGUMENTS > to the declarator->u.arg_info->parms. My understanding is that this was > meant for function prototypes, so that we can emit better diagnostics for > those. Unfortunately, start_decl doesn't always return a new decl, but > returns what pushdecl returned, which could be the new prototype, but could > be some earlier prototyped or defined function. The expansion etc. is very > unhappy if a function definition changes in the middle from having no > arguments into one with DECL_ARGUMENTs, especially if those arguments are > invalid. So, this patch limits that change to prototypes only, doesn't try > to modify a function definition. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
OK. -- Joseph S. Myers jos...@codesourcery.com
