On Wed, Dec 12, 2018 at 3:55 AM Andrew Stubbs <a...@codesourcery.com> wrote: > > > [Already approved by Jeff Law. Included here for completeness.] > > The GCN toolchain must use the LLVM assembler and linker because there's no > binutils port. The LLVM tools do not have the same diagnostic style as > binutils, so the "blank line(s) in output" tests are inappropriate (and very > noisy). > > The LLVM tools also have different command line options, so it's not possible > to autodetect object formats in the same way. > > This patch addresses both issues. > > 2018-12-12 Andrew Stubbs <a...@codesourcery.com> > > gcc/testsuite/ > * lib/file-format.exp (gcc_target_object_format): Handle AMD GCN. > * lib/gcc-dg.exp (gcc-dg-prune): Ignore blank lines from the LLVM > linker. > * lib/target-supports.exp (check_effective_target_llvm_binutils): New. > --- > gcc/testsuite/lib/file-format.exp | 3 +++ > gcc/testsuite/lib/gcc-dg.exp | 2 +- > gcc/testsuite/lib/target-supports.exp | 15 +++++++++++++++ > 3 files changed, 19 insertions(+), 1 deletion(-) >
Why do we have to call check_effective_target_offload_gcn over and over: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89095 Do we expect different answer between calls? -- H.J.
