On Fri, Jan 18, 2019 at 3:42 AM Wei Xiao <wei.william.x...@gmail.com> wrote:
>
> > > > For r267160, I'd expect you want to revert just the config/i386/ part 
> > > > and
> > > > keep the testcases, they should work even with the changes reverted, 
> > > > right?
> > > >
> > > The testcase part also need to be reverted since we have changed them
> > > according to the incorrect intrinsic list in SDM.
> >
> > I don't really understand this.
> >
> > The testcases succeed just fine for me in the current trunk with all the
> > reversions and test something the current state of the testsuite doesn't
> > check normally, in particular that the testcases run correctly even when
> > -mavx512vl is used.  As that misbehaved in the past, we should make sure we
> > don't break that again.
> >
>
> You're right. The testcases need to be kept to prevent regression.
>
> > Uros, is it ok to reapply this to current trunk?

Yes, please reapply the tests.

Thanks,
Uros.

Reply via email to