Re: [C++ Patch] Use locations[ds_storage_class] in error messages about ill-formed uses of mutable

[Martin Sebor]

On 1/15/19 9:58 AM, Paolo Carlini wrote:

Hi,

something a little different from my last patches but nevertheless pretty straightforward (noticed while I was wondering whether we should immediately move the location_t grokdeclarator local even further up). Tested x86_64-linux, as usual.

Since you're already making changes to the tests, would be too much
more work to also add quoting around static and const in the error
messages below where mutable is already quoted:

-         error ("static %qs cannot be declared %<mutable%>", name);
+         error_at (sloc, "static %qs cannot be declared %<mutable%>", name);
          storage_class = sc_none;
        }
       else if (type_quals & TYPE_QUAL_CONST)
        {
-         error ("const %qs cannot be declared %<mutable%>", name);
+         error_at (sloc, "const %qs cannot be declared %<mutable%>", name);

(I can see it being a hassle if there were many other tests where
the messages expect to find static and const with no quotes.)

Martin