On Tue, 15 Jan 2019, Jakub Jelinek wrote:

> On Tue, Jan 15, 2019 at 12:29:21PM +0530, Prathamesh Kulkarni wrote:
> > 2019-01-15  Richard Biener  <rguent...@suse.de>
> >         Prathamesh Kulkarni  <prathamesh.kulka...@linaro.org>
> > 
> >     PR ipa/88378
> 
> Wrong PR number.
> 
> >     * ipa-pure-const.c (malloc_candidate_p_1): Add parameter visited and
> >     return true if SSA_NAME is already marked in visited bitmap.
> >     * (malloc_candidate_p): Pass visited to malloc_candidate_p_1.
> > 
> > testsuite/
> >     * g++.dg/ipa/pr88788.C: New test.
> 
> The testcase looks way too large to me, can't we reduce it?
> 
> delta/creduce with a hanging compiler isn't fast (one would need to use
> timeout), but e.g. in #c1 you have a patch to get an ICE instead of hang if
> it happens.

Or just omit the testcase - even with the bitmap we can end up recursing
very many times thus the ICE can happen spuriously.

Richard.

Reply via email to