On Tue, Jan 1, 2019 at 10:02 PM Jeff Law <l...@redhat.com> wrote: > > > So the first of probably 3 patches to fix issues with string length > computations now that the underlying infrastructure is in place. Like > the prior patches, this is primarily Martin's work. My contribution has > been to break it down into more manageable hunks. > > In this patch we change the external API for get_range_strlen to pass in > the c_strlen_data pointer. Hence the various changes in client code > such as builtins.c, calls.c, tree-ssa-strlen.c, etc. > > Internally in the public get_range_strlen we also massage the result of > the internal call slightly. For example, if the internal call fails, we > set the range info to impossible values that we can check for elsewhere. > If the internal call didn't set maxbound, then we set it to an > appropriate value, etc. > > With the change in how failures are reported we twiddle the sprintf call > site slightly more than the others since it cares. Ultimately it's a > slight simplification. This patch also fixes when we set the unlikely > range. > > There's a few new tests and Martin made a couple tweaks to existing > tests that are included in this patch. > > Bootstrapped and regression tested on x86_64. My testers will iterate > on this overnight for the other targets. > > Committing to the trunk momentarily. >
This caused: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88663 -- H.J.
