On Tue, Dec 11, 2018 at 11:04 PM Tom de Vries <tdevr...@suse.de> wrote: > > [ Fixed ENOPATCH ] > > On 12-12-18 08:03, Tom de Vries wrote: > > On 11-12-18 18:59, Ian Lance Taylor wrote: > >> On Wed, Nov 28, 2018 at 4:50 AM Tom de Vries <tdevr...@suse.de> wrote: > >>> > >>> Add test-case that forces alloc.c functions to fail, and check whether > >>> fail > >>> handling is robust. > >>> > >>> This is the test-case for "[libbacktrace] Fix segfault upon allocation > >>> failure". Without that patch, this test-case fails like this: > >>> ... > >>> allocfail.sh: line 71: 26041 Segmentation fault (core dumped) \ > >>> ./allocfail $i > /dev/null 2>&1 > >>> Unallowed fail found: 13 > >>> FAIL allocfail.sh (exit status: 1) > >>> ... > >>> > >>> This is a seperate patch because the test-case is nontrivial. > >>> > >>> Bootstrapped and reg-tested on x86_64. > >>> > >>> OK for trunk? > >>> > >>> Thanks, > >>> - Tom > >>> > >>> [libbacktrace] Add allocfail.sh test-case > >>> > >>> 2018-11-27 Tom de Vries <tdevr...@suse.de> > >>> > >>> * Makefile.am (TESTS): Add allocfail.sh. > >>> (check_PROGRAMS): Add allocfail. > >>> * Makefile.in: Regenerate. > >>> * instrumented_alloc.c: New file. Redefine malloc and realloc. > >>> Include alloc.c. > >>> * allocfail.c: New file. > >>> * allocfail.sh: New file. > >> > >> Can you redo this without using GNU make features like $(filter-out) ? > > > > Hi, > > > > Done, and re-bootstrapped-and-regtested. > > > > OK for trunk?
This is OK. Thanks. Ian
