On Dec 5, 2018, Jason Merrill <ja...@redhat.com> wrote: > Hmm, I'm uncomfortable with how this depends on the specific > implementation of tentative_firewall.
*nod* > What do you think of this alternate approach (untested other than with > the testcase)? If that won't drop any other deferred access checks that we might want to keep when leaving the firewall by other paths, it looks much nicer indeed! I had been careful to only move access checks when I was certain about the replacement, but even there I was concerned about carrying stuff along with the preparsed token that didn't belong. I'm giving your proposed patch a full round of testing along with other patches. -- Alexandre Oliva, freedom fighter https://FSFLA.org/blogs/lxo Be the change, be Free! FSF Latin America board member GNU Toolchain Engineer Free Software Evangelist Hay que enGNUrecerse, pero sin perder la terGNUra jamás-GNUChe
