On 11/27/18 2:16 PM, Iain Sandoe wrote: > Hi > > This is [intentionally] broken C++ ABI, that was catering for a tool problem > that existed in a very old Darwin toolchain. > > I checked that the issue is not present after Darwin7 (using default Xcode > tools). Of course, more modern tools are probably required to build trunk > GCC for Darwin7, but somehow I doubt anyone has time to try that… > > anyway, this is long-standing breakage on all open branches. > > NOTE: re comment #18 in the PR, rs6000/darwin7.h is included after the > generic header darwin.h, and thus it is sufficient to cover the case there. > > OK for trunk? > > open branches? > > Iain > > gcc/ > > * gcc/config/darwin.h (TARGET_WEAK_NOT_IN_ARCHIVE_TOC): > Set to 0. Update comment. > * gcc/config/rs6000/darwin7.h (TARGET_WEAK_NOT_IN_ARCHIVE_TOC): New. You know the Darwin situation better than just about anyone. So if you think it's the right thing to do, then go for it.
jeff
