On Thu, 22 Nov 2018 at 19:14, Jan Hubicka <[email protected]> wrote:
>
> > On November 22, 2018 5:30:14 PM GMT+01:00, Jan Hubicka <[email protected]>
> > wrote:
> > >> * g++.dg/lto/odr-2_0.C: Remove extra brace
> > >>
> > >> diff --git a/gcc/testsuite/g++.dg/lto/odr-2_0.C
> > >b/gcc/testsuite/g++.dg/lto/odr-2_0.C
> > >> index 222fa2c1db..3ebb49efa2 100644
> > >> --- a/gcc/testsuite/g++.dg/lto/odr-2_0.C
> > >> +++ b/gcc/testsuite/g++.dg/lto/odr-2_0.C
> > >> @@ -1,5 +1,5 @@
> > >> // { dg-lto-do link }
> > >> -// { dg-lto-options { { -O0 -flto } }
> > >> +// { dg-lto-options { -O0 -flto } }
> > >
> > >Doesn't this make the testcase to be run twice, once with -O0 and
> > >second
> > >time with -flto rather than running it once with -O0 -flto?
> >
> > Yes.
>
> Actually it would be useful to have ODR tested with optimization on
> because streaming is somewhat optimization level specific. I will rework
> the testcases today so they do not need dg-lto-options
>
At least the extra { or missing } causes Tcl errors:
ERROR: tcl error sourcing /gcc/testsuite/g++.dg/lto/lto.exp.
ERROR: unmatched open brace in list
while executing
"foreach op $tmp {
set cmd [lindex $op 0]
verbose "cmd is $cmd"
if { [string match "dg-skip-if" $cmd] || [string match
"dg-require-*" $cmd] } {
..."
(procedure "lto-get-options-main" line 26)
> Honza
