Re: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87626

[Umesh Kalappa]

Thank you for the inputs and please find the attachment for the update patch.

Do please let us know your comments on the same

~Umesh
On Tue, Nov 20, 2018 at 3:03 PM Jakub Jelinek <span> wrote:
&gt;
&gt; On Mon, Nov 19, 2018 at 04:08:29PM +0530, Lokesh Janghel wrote:
&gt; diff --git a/gcc/ChangeLog b/gcc/ChangeLog
&gt; index 8ca2e73..b55dfa9 100644
&gt; --- a/gcc/ChangeLog
&gt; +++ b/gcc/ChangeLog
&gt; @@ -1,3 +1,8 @@
&gt; +2018-11-19 Lokesh Janghel <span>
&gt;
&gt; Two spaces between date and name and name and &lt;, i.e.
&gt; 2018-11-20  Lokesh Janghel  <span>
&gt; in both ChangeLog files.
&gt;
&gt; --- /dev/null
&gt; +++ b/gcc/testsuite/gcc.target/i386/pr85667-2.c
&gt; @@ -0,0 +1,15 @@
&gt; +/* { dg-do assemble } */
&gt; +/* { dg-options "-O2 -masm=intel" } */
&gt; +/* { dg-require-effective-target lp64 } */
&gt; +/* { dg-require-effective-target masm_intel } */
&gt; +/* { dg-final { scan-assembler-times "movl\[^\n\r]*, %eax" 1} } */
&gt; +typedef struct
&gt; +{
&gt; +  float x;
&gt; +} Float;
&gt; +Float __attribute__((ms_abi)) fn1 ()
&gt; +{
&gt; +  Float v;
&gt; +  v.x = 3.145;
&gt; +  return v;
&gt; +}
&gt;
&gt; This test wasn't properly tested:
&gt;
&gt; /usr/src/gcc/obj/gcc/xgcc -B/usr/src/gcc/obj/gcc/ -m64
-fno-diagnostics-show-caret -fno-diagnostics-show-line-numbers
-fdiagnostics-color=never -O2 -masm=intel -ffat-lto-objects -fno-ident
-c -o pr85667-2.o
/usr/src/gcc/gcc/testsuite/gcc.target/i386/pr85667-2.c
&gt; PASS: gcc.target/i386/pr85667-2.c (test for excess errors)
&gt; gcc.target/i386/pr85667-2.c: output file does not exist
&gt; UNRESOLVED: gcc.target/i386/pr85667-2.c scan-assembler-times
movl[^\n\r]*, %eax 1
&gt; testcase /usr/src/gcc/gcc/testsuite/gcc.target/i386/i386.exp
completed in 1 seconds
&gt;
&gt; 1) you do not want to use dg-do assemble, but dg-do compile, because only
&gt;    in that case (or when using -save-temps) assembly is produced
&gt; 2) you do not want to use -masm=intel and then expect AT&amp;T
syntax in the
&gt;    regexp
&gt;
&gt; Thus, I'd replace all the dg- directive lines with:
&gt; /* { dg-do compile { target lp64 } } */
&gt; /* { dg-options "-O2" } */
&gt; /* { dg-final { scan-assembler-times "movl\[^\n\r]*, %eax|mov\[
\t]*eax," 1 } } */
&gt;
&gt; That way, it will work both with -masm=att (explicit or implicit) or
&gt; -masm=intel.
&gt;
&gt; One can use
&gt;
&gt; make check-gcc
RUNTESTFLAGS='--target_board=unix\{-m32,-m64,-m64/-masm=intel\}
i386.exp=pr85667*'
&gt;
&gt; to verify and then look at the log file.
&gt;
&gt; Furthermore, I'd copy pr85667-1.c test to pr85667-3.c and the modified
&gt; pr85667-2.c to pr85667-4.c, change Float to Double, float to double, remove
&gt; f suffixes and adjust all the eax in the regexp to rax, so that you also
&gt; test the struct with DFmode case.
&gt;
&gt;         Jakub</span></span></span>

85667.patch
Description: Binary data