On Mon, Nov 19, 2018 at 04:21:19PM -0500, Marek Polacek wrote:
> 2018-11-19 Marek Polacek <pola...@redhat.com>
>
> Implement P1094R2, Nested inline namespaces.
> * g++.dg/cpp2a/nested-inline-ns1.C: New test.
> * g++.dg/cpp2a/nested-inline-ns2.C: New test.
> * g++.dg/cpp2a/nested-inline-ns3.C: New test.
Just a small testsuite comment.
> --- /dev/null
> +++ gcc/testsuite/g++.dg/cpp2a/nested-inline-ns1.C
> @@ -0,0 +1,26 @@
> +// P1094R2
> +// { dg-do compile { target c++2a } }
Especially because 2a testing isn't included by default, but also
to make sure it works right even with -std=c++17, wouldn't it be better to
drop the nested-inline-ns3.C test, make this test c++17 or
even better always enabled, add dg-options "-Wpedantic" and
just add dg-warning with c++17_down and c++14_down what should be
warned on the 3 lines (with .-1 for c++14_down)?
Or if you want add some further testcases that will test how
c++17 etc. will dg-error on those with -pedantic-errors etc.
> +
> +namespace A::inline B::C {
> + int i;
> +}
> +
> +namespace D::E::inline F {
> + int j;
> +}
> +
> +inline namespace X {
> + int x;
> +}
> +// Make sure the namespaces are marked inline.
> +void
> +g ()
> +{
> + A::B::C::i++;
> + A::C::i++;
> + D::E::j++;
> + D::E::F::j++;
> + X::x++;
> + x++;
> +}
Jakub
