Hi Aaron,

On Wed, Nov 14, 2018 at 10:42:44AM -0600, Aaron Sawdey wrote:
> +static rtx
> +emit_vsx_zero_reg()
> +{
> +  unsigned int i;
> +  rtx zr[16];
> +  for (i = 0; i < 16; i++)
> +    zr[i] = GEN_INT (0);
> +  rtvec zv = gen_rtvec_v (16, zr);
> +  rtx zero_reg = gen_reg_rtx (V16QImode);
> +  rs6000_expand_vector_init (zero_reg, gen_rtx_PARALLEL (V16QImode, zv));
> +  return zero_reg;
> +}

use CONST0_RTX (V16QImode) ?

> +      emit_insn (gen_altivec_vsldoi_v16qi 
> (result_shifted,result_gbbd,result_gbbd, GEN_INT (shift_amt)));

This line is a bit^H^H^H^H^Hsomewhat^H^H^H^H^H^H^H^Hvery terribly quite much 
too long :-)

And there should be spaces after each comma.

This would have been a lot easier to review if you could have separated
the refactoring to a first patch, and the actual changes to a second.

But it's okay for trunk.  Please fix the long line, and maybe look if
CONST0_RTX helps you.  Thanks for the patch!

(Also fine with switching the cutoff to 33).


Segher

Reply via email to