On Thu, Nov 8, 2018 at 1:17 PM Aldy Hernandez <al...@redhat.com> wrote: > > This one's rather obvious and does not depend on any get_range_info API > change. > > OK for trunk?
Hmm, no - that's broken. IIRC m_equiv are shared bitmaps if you do tem = *old_vr so you modify it in place with equiv_clear(). Thus, operator= should be really deleted or mapped to value_range::set() in which case tem = *old_vr would do useless bitmap allocation and copying that you then clear. It's also two lines of code instead of one. Richard.