Hi Paul,
On Mon, Oct 22, 2018 at 01:25:57PM -0500, Paul Clarke wrote:
> This is a follow-on to earlier commits for adding compatibility
> implementations of x86 intrinsics for PPC64LE. This patch adds
> the 32 x86 intrinsics from <tmmintrin.h> ("SSSE3").
> +extern __inline __m64 __attribute__((__gnu_inline__, __always_inline__,
> __artificial__))
You could make this fit on a line by wrapping before the __attribute__.
This is true for previous patches as well of course, but it kind of
annoys me in this one.
> +_mm_alignr_pi8 (__m64 __A, __m64 __B, unsigned int __count)
> +{
> + if (__count < 16)
> + {
Indentation is broken here and elsewhere in this file. Please fix.
if (...)
{
blabla;
blabla;
}
else
{
blabla;
blabla;
}
> + __v2du __C = {__B, __A};
> +#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
> + const __v4su __shift = {__count << 3, 0, 0, 0};
> + __C = (__v2du) vec_sro ((__v16qu)__C,(__v16qu) __shift);
Space after cast. Space after comma.
> +#else
> + const __v4su __shift = { 0, 0, 0, __count << 3 };
Sometimes you put spaces inside {} and sometimes not. Please choose one?
Common style is with.
This is okay for trunk if made a bit more readable (by following the usual
coding style rules, say ;-) )
Segher
